Add search box to CourseEnrollmentAllowed admin interface. - #16166
Conversation
|
Thanks for the pull request, @smarnach! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request. |
|
Thanks for the pull request, @smarnach! I've created OSPR-1943 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
openedx-webhooks
added
needs triage
open-source-contribution
There was a problem hiding this comment.
Nit: It seems like all tuple and list definitions in the other classes also include a comma at the end. Maybe better to do that here too, for consistency.
There was a problem hiding this comment.
OK, changed that. (Some people prefer the trailing comma since it avoids a pitfall when reducing the length of the tuple to one. It's not done consistently in edx-platform, but seems to be done in this particular file.)
591b1da to
17194ae
Compare
|
@cgopalan The sandbox is now available – see the link in the PR description. |
cgopalan
left a comment
cgopalan
left a comment
There was a problem hiding this comment.
👍
- I tested this: Checked that the search field was visible and functional on the Student/Course Enrollment Allowed admin page.
- I read through the code
-
I checked for accessibility issues -
Includes documentation
|
@smarnach seems like the jenkins/lettuce build failed. Not sure what the reason was. How do we trigger it again? |
|
jenkins run lettuce |
|
@cgopalan We can ask Jenkins to rerun the tests from the PR, but I'm not sure you would have permission. |
|
@mjfrey Thanks! |
|
@smarnach 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, December 12, 2017. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
6 participants
This adds a search field to the
CourseEnrollmentAllowedadmin interface, and configures the list view to show individual fields instead of a string representation of the whole instance.JIRA tickets: OSPR-1943
Discussions: None
Dependencies: None
Screenshots:
Without this change:
With this change applied:
Sandbox URL: https://pr16166.sandbox.opencraft.hosting/
Merge deadline: None
Testing instructions:
Navigate to https://pr16166.sandbox.opencraft.hosting/admin/student/courseenrollmentallowed/, log in as the standard staff user and try it.
Author notes and concerns: None
Reviewers